Any chances to get Shellcheck onboard ?

[netflash]

Hi there,

any chances you can get https://github.com/koalaman/shellcheck onboard ?
Would love to have it to check bash scripts.

[rarkins]

Yes, no problem - I'll add shortly or feel free to submit a PR in the meantime

[rarkins]

After some quick reading, it seems that shellcheck isn't as simple as some other linters.

It's not supported directly by alpine linux:
https://bugs.alpinelinux.org/issues/6417
http://bugs.alpinelinux.org/issues/7105

Here's an example docker image that incorporates alpine + shellcheck: https://github.com/NLKNguyen/alpine-shellcheck

The only problem is that it involves manual steps, while this repo is auto-built by Docker Hub. It could still be possible but needs more thought.

[rarkins]

One (ugly) possibility would be to simply commit the shellcheck binary to this repo and copy it into the Docker image.

[netflash]

Nice findings!
I find Docker Hub and Quay native build processes not good for separate build container approach :-(

Thought of using releases https://github.com/koalaman/shellcheck/releases , but there's source code only...

[damiendurant]

Hi,

I compile the shellcheck on this fork : https://github.com/damiendurant/lint-condo.git

It's based on work done on mhart/alpine-node
Therefore, currently the image is 600M ,still looking to downsize it before to merge request.