TDL-19486 Add limit clause to core stream queries - #68
Merged
dsprayberry merged 15 commits intoJul 5, 2022
Conversation
savan-chovatiya
approved these changes
Jun 17, 2022
dsprayberry
requested changes
Jun 17, 2022
dsprayberry
approved these changes
Jun 21, 2022
kspeer825
suggested changes
Jun 21, 2022
| "limit": value | ||
| } | ||
|
|
||
| class TestQueryLimitParam(unittest.TestCase): |
Contributor
There was a problem hiding this comment.
These are good test cases.
kspeer825
approved these changes
Jun 24, 2022
2 tasks
bryantgray
approved these changes
Jul 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
LIMITparameter is added for all core streams except the below streams,call_detailscampaign_lablesad_group_criterioncampaign_criterionLIMITclauses in thead_group_criterionandcampaign_criterion(stream which has composite primary keys) may result in the infinite loop.WHERE campaign_id >= 1WHERE pk_1 > 1 OR (pk_1 = 1 and pk_2 > 1)because google ads do not support OR parameter. We had a slack conversation about the same.query_limitparameterQA steps
Risks
Rollback steps