Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canonicalize transactions in OrderRefunds for TDL-21280 #156

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Canonicalize transactions in OrderRefunds for TDL-21280 #156

merged 3 commits into from
Nov 30, 2022

Conversation

dsprayberry
Copy link
Contributor

@dsprayberry dsprayberry commented Nov 21, 2022 •
edited
Loading

Description of change

  • Moves canonicalization to base
  • Adds canonicalization use to OrderRefunds (in addition to transactions)

QA steps

  • automated tests passing
  • manual qa steps passing (list below)
    • Ran tap locally and validated output.

Risks

  • If users have built reports on the uppercase versions of these fields, those would break.

Rollback steps

  • revert this branch

@dsprayberry dsprayberry changed the title Canonicalize transactions in OrderRefunds Canonicalize transactions in OrderRefunds for TDL-21280 Nov 21, 2022
dmosorast
dmosorast requested changes Nov 30, 2022
View reviewed changes
tap_shopify/streams/order_refunds.py Outdated Show resolved Hide resolved
@dmosorast dmosorast merged commit 60c5935 into master Nov 30, 2022
@dmosorast dmosorast deleted the fix/order_refund_canonicalization branch November 30, 2022 18:26
RushiT0122 pushed a commit that referenced this pull request May 22, 2023
@dsprayberry @RushiT0122
Canonicalize transactions in OrderRefunds for TDL-21280 (#156)
6279943 
* Canonicalize transactions in OrderRefunds

* Move canonicalize to base

* Version Bump and Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmosorast dmosorast dmosorast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsprayberry @dmosorast