fix: context menu behavior in mouse, desktop env #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EchoEllet
reviewed
Jul 5, 2024
| @@ -167,7 +169,7 @@ class EditorTextSelectionGestureDetectorBuilder { | |||
| null, | |||
| SelectionChangedCause.forcePress, | |||
| ); | |||
| if (shouldShowSelectionToolbar) { | |||
| if (shouldShowSelectionToolbar && !requiresAdditionalActionForToolbar) { | |||
There was a problem hiding this comment.
We might consider extractring this check into its own function or getter as it's become a bit harder to maintain. In the future, someone might add new features or bugs to fix and update some of the checks and forget the others.
And we also don't have tests to cover those cases.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When drag or select text with the mouse in a desktop environment, a context menu always appears.
The typical behavior in a desktop environment is that it does not appear when dragging/selecting, but when additionally press the right-click button.
Related Issues
Checklist
CHANGELOG.mdnor the package version inpubspec.yamlfiles../scripts/before_push.shand it all passed successfullyBreaking Change
Does your PR require developers to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).