Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r] More renames SOMAReader -> SOMAArrayReader #1191

Merged
merged 1 commit into from Mar 28, 2023
Merged

[r] More renames SOMAReader -> SOMAArrayReader #1191

merged 1 commit into from Mar 28, 2023

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Mar 28, 2023 •
edited

Continues #1147, #1173, #1174

@johnkerl johnkerl marked this pull request as ready for review March 28, 2023 20:26
@johnkerl johnkerl requested review from mojaveazure and aaronwolen and removed request for BAevermann March 28, 2023 20:26
eddelbuettel
eddelbuettel approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@johnkerl johnkerl merged commit 760fd86 into main Mar 28, 2023
3 checks passed
@johnkerl johnkerl deleted the kerl/more-renames branch March 28, 2023 20:47
@johnkerl johnkerl mentioned this pull request Mar 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddelbuettel eddelbuettel eddelbuettel approved these changes

@mojaveazure mojaveazure Awaiting requested review from mojaveazure

@aaronwolen aaronwolen Awaiting requested review from aaronwolen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnkerl @eddelbuettel