[Backport release-1.11] [python] version.py: prevent Git version computation from raiseing
#2636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* `version.py`: prevent Git version computation from `raise`ing * `version.py`: ensure `__file__ == "apis/python/version.py"` relative to Git root
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.11 #2636 +/- ##
=============================================
Coverage 90.24% 90.24%
=============================================
Files 37 37
Lines 4038 4038
=============================================
Hits 3644 3644
Misses 394 394
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
approved these changes
May 23, 2024
johnkerl
changed the title
version.py: prevent Git version computation from raiseingversion.py: prevent Git version computation from raiseing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2f9d6bb from #2624