add print_my_channels option for mpe-client #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snet_cli/utils.py
Outdated
|
|
||
| # return element of abi (return None if fails to find) | ||
| def abi_get_element_by_name(abi, name): | ||
| for a in abi["abi"]: |
There was a problem hiding this comment.
Will "abi" key always be within abi dict?
If not or abi == None, this for loop will break.
I'd suggest use something like if abi and "abi" in abi:
Offtopic: There are too much off abi in this line...
The call/transact_contract_command is a very good improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add print_my_channels option to mpe-client (print all channels which belongs to the client). This is the first element in stateless client logic.
Moreover I've added helper function to class BlockchainCommand: call_contract_command and transact_contract_command. Using this functions we can remove all ugly "ContractCommand" calls.