Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup internals #102

Closed
2 tasks done
sinhrks opened this issue Jan 17, 2016 · 3 comments
Closed
2 tasks done

Cleanup internals #102

sinhrks opened this issue Jan 17, 2016 · 3 comments

Comments

@sinhrks
Copy link
Owner

sinhrks commented Jan 17, 2016 •
edited
Loading

  • Make post_fortify to always attach base_class
  • Move ggplot instanciation to geom_factory, do not include duplicated data to geom.
@DarioS
Copy link
Contributor

DarioS commented Feb 8, 2017

Additionally to the above two issues, the last parameter of fortify.survfit is ... but it is never used in the body of the function. Also, the documentation states that ... other arguments passed to methods which is incorrect. Its contents are not passed anywhere.

@DarioS DarioS mentioned this issue Feb 8, 2017
Closed
@DarioS
Copy link
Contributor

DarioS commented Feb 8, 2017

Different permissible geoms according to documentation @param surv.geom geometric string for survival curve. 'step' or line' and code geomfunc <- get_geom_function(surv.geom, allowed = c('step', 'line', 'point')). point is allowed, but not described in the documentation.

@sinhrks
Copy link
Owner Author

sinhrks commented Feb 9, 2017 •
edited
Loading

Thx for the comment. Yeah it should be fixed.

Also updated the top checkboxes as these has been fixed already :)

@sinhrks sinhrks mentioned this issue Feb 15, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DarioS @sinhrks