Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests are not executing in a browser #68

Closed
fatso83 opened this issue Oct 10, 2018 · 1 comment
Closed

Tests are not executing in a browser #68

fatso83 opened this issue Oct 10, 2018 · 1 comment
Labels
help wanted

Comments

@fatso83
Copy link
Contributor

fatso83 commented Oct 10, 2018

Given that this is the only sinonjs/* library that exclusively deals with browsers, it's perplexing that it's the only one not running tests in a browser 😮 That makes it hard to verify run-time issues in browsers, such as #61 (and the fix in #67).

We should add mochito (running Puppeteer) like in the other projects.
@fatso83 fatso83 changed the title Tests are not executing in a browse4r Tests are not executing in a browser Oct 10, 2018
@sebcanonica sebcanonica mentioned this issue Oct 14, 2018
Merged
@fatso83
Copy link
Contributor Author

fatso83 commented Oct 14, 2018

Closed by the generous @sebcanonica in #69 :-)

@fatso83 fatso83 closed this as completed Oct 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mroderick @fatso83