Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce isUndefined and deprecate defined #89

Closed
mantoni opened this issue Feb 27, 2019 · 0 comments
Closed

Introduce isUndefined and deprecate defined #89

mantoni opened this issue Feb 27, 2019 · 0 comments
Labels
semver:major changes will cause a new major version
Milestone
4.0

Comments

@mantoni
Copy link
Member

mantoni commented Feb 27, 2019

As suggested by @mroderick in #87 we should introduce isUndefined and deprecate defined to align with isNull, isTrue, etc.
@mantoni mantoni added the semver:major changes will cause a new major version label Feb 27, 2019
@mantoni mantoni added this to the 4.0 milestone Feb 27, 2019
@mroderick mroderick mentioned this issue Feb 27, 2019
Merged
2 tasks
mgred added a commit that referenced this issue Feb 28, 2019
@mgred
feat(isUndefined): add new assetion isUndefined
28a2705 
check if an actual value is undefined

See: #89 #87
mgred added a commit that referenced this issue Feb 28, 2019
@mgred
remove(defined): deprecate in favor of isUndefined
f49dfd9 
See: #89 #87
@mgred mgred mentioned this issue Feb 28, 2019
Merged
2 tasks
mgred added a commit that referenced this issue Mar 6, 2019
@mgred
Introduce isUndefined, deprecate defined (#93)
c8f8951 
* feat(isUndefined): add new assetion isUndefined

check if an actual value is undefined

See: #89 #87

* chore: update commons package

to use deprecated wrapper

* deprecate(defined): add warning wrapper
@mantoni mantoni closed this as completed Mar 9, 2019
@mantoni mantoni mentioned this issue Mar 9, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
semver:major changes will cause a new major version
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
1 participant
@mantoni