Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated defined API #95

Merged
merged 3 commits into from
Mar 9, 2019
Merged

Remove deprecated defined API #95

merged 3 commits into from
Mar 9, 2019

Conversation

mantoni
Copy link
Member

@mantoni mantoni commented Mar 9, 2019

Purpose (TL;DR) - mandatory

The assert.defined and refute.defined APIs have been deprecated in favor of assert.isUndefined and refute.isUndefined to be in line with other APIs like isNull. This change removes defined from the API.

Ref #89 #93

How to verify - mandatory

  1. Check out this branch
  2. npm install
  3. npm t

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

@mantoni mantoni added the semver:major changes will cause a new major version label Mar 9, 2019
@mantoni mantoni added this to the 4.0 milestone Mar 9, 2019
@coveralls
Copy link

coveralls commented Mar 9, 2019

Pull Request Test Coverage Report for Build 319

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 315: 0.0%
Covered Lines: 654
Relevant Lines: 654

💛 - Coveralls

@@ -139,7 +139,6 @@ These assertions are for checking for built-in types and values.
* [`isMap()`](#ismap)
* [`isNaN()`](#isnan)
* [`isNegativeInfinity()`](#isnegativeinfinity)
* [`isNull()`](#isnull)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated in line 122.

@mantoni mantoni merged commit c79b1e6 into master Mar 9, 2019
@mantoni mantoni deleted the remove-defined branch March 9, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:major changes will cause a new major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants