-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QR code comparison #10
Comments
Hmm, would there be a way to generate these on the fly? The size of the QR code will depend on the address type. |
Thinking more about it, it's a bit more complicated as you can't just convert a segwit address to an old-style address. I'll add an extra box for encoding, which lets you enter a pubkey or a script, and constructs the P2PKH/P2WPKH or P2SH/P2WSH address for it, as well as the QR code for it. |
Oh I see. Drak asked me, but he gave these images. |
@romanornr Right, but I'll do the work of generating addresses first - something the current JS code does not support. |
Checking in |
Hello me |
Hi Pieter,
I got asked to add the QR code comparison.
I noticed you cleaned your git repo history up.
I couldn't make a pull request because of it.
But can you do a git cherry pick?
romanornr@408c7be
The text was updated successfully, but these errors were encountered: