Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR code comparison #10

Open
romanornr opened this issue Mar 21, 2017 · 7 comments
Open

QR code comparison #10

romanornr opened this issue Mar 21, 2017 · 7 comments

Comments

@romanornr
Copy link
Contributor

Hi Pieter,

I got asked to add the QR code comparison.
I noticed you cleaned your git repo history up.

I couldn't make a pull request because of it.
But can you do a git cherry pick?
romanornr@408c7be

x-screenshot from 2017-03-21 21-11-08

@sipa
Copy link
Owner

sipa commented Mar 21, 2017

Hmm, would there be a way to generate these on the fly? The size of the QR code will depend on the address type.

@sipa
Copy link
Owner

sipa commented Mar 21, 2017

Thinking more about it, it's a bit more complicated as you can't just convert a segwit address to an old-style address. I'll add an extra box for encoding, which lets you enter a pubkey or a script, and constructs the P2PKH/P2WPKH or P2SH/P2WSH address for it, as well as the QR code for it.

@romanornr
Copy link
Contributor Author

Oh I see. Drak asked me, but he gave these images.
So what you want is generating QR codes and showing that on the demo page ?

@sipa
Copy link
Owner

sipa commented Mar 21, 2017

@romanornr Right, but I'll do the work of generating addresses first - something the current JS code does not support.

@romanornr
Copy link
Contributor Author

It probably doesn't work this way?

hmmmseg

@P33LLo
Copy link

P33LLo commented Jan 26, 2018

Checking in

@Tawat99
Copy link

Tawat99 commented Sep 16, 2018

Hello me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants