Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

captureplan: sip_check() fix for harmless error logging #67

Closed
dougbtv opened this issue May 26, 2016 · 1 comment
Closed

captureplan: sip_check() fix for harmless error logging #67

dougbtv opened this issue May 26, 2016 · 1 comment

Comments

@dougbtv
Copy link
Member

dougbtv commented May 26, 2016

So I noticed when using sip_check() in capture plan to limit what messaging to capture, that there's some harmless error messages in the logs, I think there's a missing else-if in protocol_sip.c

If you're doing something like sip_check("method","REGISTER") in a capture plan, you'll get a harmless error stating:

[ERR] protocol_sip.c:195 unknown variable [method]

Need an else-if here:

Otherwise you get this error message:

LERR("unknown variable [%s]\n", param1);

I'll submit a PR as soon as I get a chance. It's not breaking, but, it appears as an error when you're kind of not expecting it.

@dougbtv
Copy link
Member Author

dougbtv commented May 27, 2016

Closed up in #69

@dougbtv dougbtv closed this as completed May 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant