Updated fmt library to v10 to address some compilation issues on macOS 13 #1506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! I encountered some compilation errors on macOS Ventura, likely from the very different C++ compiler (see below). I was able to pull in the most recent release of the
fmt
library and fix the issues introduced there by casting a few arguments being formatted. I'm not 100% sure I did everything properly, but I figured it would be good to see the CI results. With these fixes,slade
builds and runs on my M1 Mac laptop.Here are the errors I saw from the version of
fmt
in themaster
branch: