Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on windows resize event #31

Closed
AminulBD opened this issue Apr 16, 2017 · 4 comments
Closed

on windows resize event #31

AminulBD opened this issue Apr 16, 2017 · 4 comments
Labels

Comments

@AminulBD
Copy link

Ripples not working great when the window is resized. I think reinitialize needed on window resize.

What do you think?

@sirxemic
Copy link
Owner

sirxemic commented Apr 17, 2017

You'll need to be a little bit more specific. The canvas is resized to its parent when the window is resized, or is supposed to, at least. Could you show me the HTML and the CSS you are using for the element you are applying the effect to?

@AminulBD
Copy link
Author

Oh, Later I get that it's working fine on window resize event. But, If the element has transition property then this will not work great.

Here you can get live example: https://codepen.io/aminul/full/WjxoyK/

Resize window (Height) then you will see what's is going there.

@sirxemic sirxemic added the bug label Apr 22, 2017
@sirxemic
Copy link
Owner

The issue in that example isn't the window resize, it's that the canvas element doesn't resize when its parent's CSS is updated.

Here is an example how you can fix it with a workaround:
https://codepen.io/anon/pen/Vbjrjz

@AminulBD
Copy link
Author

Owao! Simple. But, I didn't understand this simple thing before. 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants