Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example notebooks to docs #64

Merged
merged 30 commits into from
Mar 8, 2020

Conversation

mattuntergassmair
Copy link
Collaborator

@mattuntergassmair mattuntergassmair commented Mar 1, 2020

Move IJulia example notebooks to the documentation folder, make sure plots are auto-generated when docs are created.

2DStadium has already been moved, remaining examples will be moved shortly. Eventually, all content will be migrated to the docs and IJulia notebooks and tutorials folder can be removed.

Fixes #62

@coveralls
Copy link

coveralls commented Mar 1, 2020

Coverage Status

Coverage decreased (-1.4%) to 76.08% when pulling 8b14783 on mattuntergassmair:notebooks_to_docs into 959ac68 on sisl:master.

@MaximeBouton
Copy link
Member

Does this also includes change for AutoViz v0.8 or can it be merged directly?

@MaximeBouton
Copy link
Member

oh I see that AutoViz is constrained to v0.8.
We can close #59 then?

@mattuntergassmair
Copy link
Collaborator Author

mattuntergassmair commented Mar 2, 2020

oh I see that AutoViz is constrained to v0.8.
We can close #59 then?

Ouh, I didn't see #59

But yes, this is for AutoViz v0.8.

Note that this PR is still work in progress, I just opened a PR so it could be reviewed on a rolling basis.

Maybe it is worth cross-checking this with #59 before merging

@MaximeBouton MaximeBouton mentioned this pull request Mar 2, 2020
17 tasks
@mattuntergassmair
Copy link
Collaborator Author

Tim2DDriver and MOBIL were currently not working with new ADM interface. Fixed the implementations as part of this PR, even though it should technically have been a separate one. There are some deeper issues with FeatureExtraction which can be addressed in a separate PR.

src/behaviors/sidewalk_pedestrian_model.jl Show resolved Hide resolved
docs/src/examples.md Outdated Show resolved Hide resolved
docs/src/index.md Outdated Show resolved Hide resolved
src/behaviors/MOBIL.jl Show resolved Hide resolved
src/behaviors/MOBIL.jl Outdated Show resolved Hide resolved
src/behaviors/tim_2d_driver.jl Show resolved Hide resolved
docs/src/examples/stadium.md Show resolved Hide resolved
src/feature-extraction/features.jl Outdated Show resolved Hide resolved
src/behaviors/MOBIL.jl Outdated Show resolved Hide resolved
@MaximeBouton
Copy link
Member

The failing test is due to MOBIL

src/behaviors/tim_2d_driver.jl Outdated Show resolved Hide resolved
@mattuntergassmair
Copy link
Collaborator Author

The failing test is due to MOBIL

I was sloppy in replacing some of the extractor functions - should be fixed now

@MaximeBouton
Copy link
Member

I think you need Reel in the docs/Project.toml

@MaximeBouton
Copy link
Member

I don't understand why the documentation stage does not show up in travis...

@MaximeBouton MaximeBouton merged commit fac1aa2 into sisl:master Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tim2DDriver relies on QueueRecord
3 participants