Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 0.8 #66

Closed
17 tasks done
MaximeBouton opened this issue Mar 2, 2020 · 7 comments
Closed
17 tasks done

version 0.8 #66

MaximeBouton opened this issue Mar 2, 2020 · 7 comments
Milestone

Comments

@MaximeBouton
Copy link
Member

MaximeBouton commented Mar 2, 2020

As AutoViz is moving towards a version 0.8 maybe this package should move on as well.
Here is a description of stuff to do:

Drop support for deprecated functions:

  • simulate
  • state1D
  • get_name
  • Scene and Vehicle aliases
@mattuntergassmair
Copy link
Collaborator

#64 is now ready to review

As for State1D, what is the main reason we are dropping it? I have not used it before but one case where I think it could be useful would be for macroscopic traffic simulations on large road networks, where overall traffic flow is modeled. Also, it is currently used for the Straight Rowadway example in the docs so if we drop it we should re-write that example for 2D vehicles.
I was able to make State1D work with the new interface by introducing posf, posg, are there other aspects which make it unuseable in the new interface?
PR #64 currently needs support for State1D for the straight roadway example, but we can delete it if we re-do the Straight Roadway example.

@mattuntergassmair
Copy link
Collaborator

What is the reason for deprecating get_name and are there alternatives?

@MaximeBouton
Copy link
Member Author

I don't think there is any use for get_name.
The case for State1D is arguable but I am not super convinced...

@mattuntergassmair
Copy link
Collaborator

I don't think there is any use for get_name.
The case for State1D is arguable but I am not super convinced...

I was using get_name in my GUI to display the model which each of the agents is following (including model parameters), i.e. IDM s0 2.0 T 1.5 or similar. Could easily work around to make it work without get_name, just want to make sure we are certain about deprecating it.
Same for State1D but as mentioned earlier for macroscopic simulations State1D may be more lightweight

@MaximeBouton
Copy link
Member Author

I think typeof would work in that case?

@mattuntergassmair
Copy link
Collaborator

In some cases you may want something more specific than typeof, such as IDM s0 2.0 T 1.5 instead of IntelligentDriverModel. But I think I am also in favor of removing get_name from the interface - users can always implement get_name for the models of interest outside of ADM.

@MaximeBouton MaximeBouton added this to the v0.8 milestone Mar 11, 2020
@MaximeBouton
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants