Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #15. Remove eval from __init__ to allow precompilation. #17

Merged
merged 1 commit into from May 28, 2021
Merged

fix #15. Remove eval from __init__ to allow precompilation. #17

merged 1 commit into from May 28, 2021

Conversation

tomerarnon
Copy link
Collaborator

No description provided.

@tomerarnon tomerarnon requested a review from mykelk May 27, 2021 23:40
@tomerarnon tomerarnon mentioned this pull request May 27, 2021
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 13.149% when pulling c9b6da6 on fix/#15 into a7a4a8a on master.

blegat
blegat approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue for https://github.com/dionysos-dev/Dionysos.jl as well

@mykelk mykelk merged commit 83478d2 into master May 28, 2021
@mykelk mykelk deleted the fix/#15 branch May 28, 2021 14:14
@blegat blegat mentioned this pull request May 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blegat blegat blegat approved these changes

@mykelk mykelk Awaiting requested review from mykelk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tomerarnon @coveralls @blegat @mykelk