New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compatibility info to project.toml #35
Conversation
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
==========================================
- Coverage 81.63% 80.74% -0.89%
==========================================
Files 12 12
Lines 343 296 -47
==========================================
- Hits 280 239 -41
+ Misses 63 57 -6
Continue to review full report at Codecov.
|
@radioflash Thank you again. What a great service 💪 We really should setup CompatHelper for this repository after this. One thing that has always bugged me is that, in the case of un-resolvable version constraints with other package, Julia will "figure out" that it can just use an older version of the package that does not have any compat entry at all (because, seemingly, that is compatible with all versions). Do you know how to work around that? Or is this not a problem anymore, now that everything has a "virtual" compat entry in the general registry? |
I've not encountered that problem myself so far (instead I often get dependencies stuck on old versions because some package is not listing the latest in its compat, even though it would work). I think the introduction of the "virtual compat" entries in the registry prevents this, but I'm not 100% positive on that. |
@zsunberg do you know more about this? |
I have encountered the problem that you talked about where it "upgrades" to an old version, but I am not sure if it is fixed by the registry virtual compat. I would not worry too much about supporting old versions |
I have asked on the Julia slack, the problem is indeed gone:
|
Nice :) Thank you for the info! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I will tag a new version on the coming weekend unless you have any objections, @jamgochiana |
Some Distributions versions (v0.21, v0.22, v0.23) were left out because the tests failed with them (on windows Julia 1.6)
All other listed versions worked (but not every permutation was tested).
Hyphens were not used in version specifications because those officially require Julia 1.4 or newer.
This version specification is stricter than the autogenerated one in the Julia package registry, but
this is reasonable:
The oldest (now declared compatible) dependency releases are from 2018 (older than this package itself).