Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes #106

Merged
merged 3 commits into from Jul 14, 2020
Merged

Nodes #106

merged 3 commits into from Jul 14, 2020

Conversation

tomerarnon
Copy link
Collaborator

Noticed in #105 that Node really isn't required for maxsens.
It also should be quite possible to write it using our own approximate_affine_map or LazySet's overapproximate (probably). For example, we can write it as

function forward_layer(solver::MaxSens, L::Layer, input::Hyperrectangle)
    output = approximate_affine_map(L,  input)
    β = L.activation.(center(output))
    βmax = L.activation.(high(output)
    βmin = L.activation.(low(deviation))
    #etc.

end
return Hyperrectangle(center, gamma)
end
output = approximate_affine_map(L, input)
Copy link
Collaborator Author

@tomerarnon tomerarnon Jul 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

output = overapproximate(AffineMap(L.weights, input, L.bias)) is another option for this line. Any preference on which is clearer for the paper @changliuliu?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like approximate_affine_map

Copy link
Collaborator

@changliuliu changliuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new implementation is very neat!

end
return Hyperrectangle(center, gamma)
end
output = approximate_affine_map(L, input)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like approximate_affine_map

@changliuliu changliuliu merged commit 615d111 into master Jul 14, 2020
@tomerarnon tomerarnon deleted the nodes branch July 23, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants