Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use Cxx and BinaryBuilder #8

Merged
merged 22 commits into from
Sep 24, 2019
Merged

[WIP] Use Cxx and BinaryBuilder #8

merged 22 commits into from
Sep 24, 2019

Conversation

MaximeBouton
Copy link
Member

@MaximeBouton MaximeBouton commented Jul 22, 2019

Try to avoid calling python and directly calls libspot.so instead.

Current Issues:

TODOs:

  • Finish wrapping existing functions
  • Ensure latex rendering of formulas is working
  • Ensure Tikz rendering of automata is working

@codecov-io
Copy link

codecov-io commented Aug 18, 2019

Codecov Report

Merging #8 into master will increase coverage by 15.45%.
The diff coverage is 89.52%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #8       +/-   ##
===========================================
+ Coverage   75.17%   90.62%   +15.45%     
===========================================
  Files           6        5        -1     
  Lines         145      160       +15     
===========================================
+ Hits          109      145       +36     
+ Misses         36       15       -21
Impacted Files Coverage Δ
src/Spot.jl 100% <100%> (ø) ⬆️
src/rabin_automata.jl 93.93% <100%> (+0.6%) ⬆️
src/automata.jl 86.76% <80.95%> (+14.03%) ⬆️
src/translator.jl 91.66% <91.66%> (-8.34%) ⬇️
src/formulas.jl 88.88% <93.75%> (+10.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 408e862...752dcaf. Read the comment docs.

@MaximeBouton
Copy link
Member Author

Works locally on windows!
not in travis yet...

@MaximeBouton MaximeBouton merged commit e897273 into master Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants