Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a pre response hook for plugins #71

Closed
m1h43l opened this issue May 10, 2019 · 2 comments
Closed

Add support for a pre response hook for plugins #71

m1h43l opened this issue May 10, 2019 · 2 comments

Comments

@m1h43l
Copy link
Collaborator

m1h43l commented May 10, 2019

We need to be able to hook into the response before it is send over the network.

Sometimes the response needs to be modified before sending f. e. CORS support, #34 . CORS needs to add some extra headers to the response.

@m1h43l
Copy link
Collaborator Author

m1h43l commented Jul 31, 2020

@NielsLiisberg As the response struct is already available to the plugin as a parameter can we already add the HTTP header on the existing pre request hook? Then at least for setting the CORS headers there is no need for any additional hooks.

@m1h43l
Copy link
Collaborator Author

m1h43l commented Aug 24, 2020

Reponse data structure is also available in the PRE_REQUEST hook. So we can also modify the response there. Is good enough for me atm.

@m1h43l m1h43l closed this as completed Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant