Use resultBaseDir as in 3.x #1583 #1584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobli
reviewed
Apr 23, 2017
| @@ -26,7 +26,11 @@ module.exports = function(input, timestamp, outputFolder, resultBaseURL) { | |||
| storageBasePath = path.resolve(outputFolder); | |||
| } else { | |||
| resultsSubFolders.push(getDomainOrFileName(input), timestamp.format('YYYY-MM-DD-HH-mm-ss')); | |||
| storageBasePath = path.resolve('sitespeed-result', ...resultsSubFolders); | |||
| if (resultBaseDir) { | |||
| storageBasePath = path.resolve(resultBaseDir,'sitespeed-result', ...resultsSubFolders); | |||
There was a problem hiding this comment.
According to the cli description, the sitespeed-result should not be added to this path.
tobli
reviewed
Apr 23, 2017
| @@ -521,7 +521,10 @@ module.exports.parseCommandLine = function parseCommandLine() { | |||
| type: 'boolean' | |||
| }) | |||
| .option('outputFolder', { | |||
| describe: 'The folder where the result will be stored.' | |||
| describe: 'The folder where the result will be stored, disabling hostname/date in the URL' | |||
There was a problem hiding this comment.
Maybe clearer as "hostname/date will not be appended to path"?
tobli
reviewed
Apr 23, 2017
| @@ -15,7 +15,7 @@ function getDomainOrFileName(input) { | |||
| return domainOrFile; | |||
| } | |||
|
|
|||
| module.exports = function(input, timestamp, outputFolder, resultBaseURL) { | |||
| module.exports = function(input, timestamp, outputFolder, resultBaseURL, resultBaseDir) { | |||
There was a problem hiding this comment.
I'd prefer to keep the two path related parameters next to each other in the parameter list, and keep the URL last.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.