Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getRowCount() should return 0 if first non-header row does not have values #21

Closed
fhoeben opened this issue Oct 13, 2017 · 1 comment
Closed

Comments

@fhoeben
Copy link
Contributor

fhoeben commented Oct 13, 2017

Currently getRowCount() just counts the number of rows beyond the header, but if no results are returned there is a first row. So getRowCount() returns 1.
But that first row does not have any values, leading to errors later on when one calls getColumnValueByName().

When a query returns no results the 'row count' should be 0, correct?

Is that empty row required for the usage as 'table', or could it just be removed altogether?

@Unforgettable631
Copy link
Contributor

We are also facing this issue just a few days ago. Looking forward for when your fix will be merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants