Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to define token type #650

Open
Tracked by #2492
chriskerr-performio opened this issue Apr 28, 2022 · 6 comments
Open
Tracked by #2492

Add ability to define token type #650

chriskerr-performio opened this issue Apr 28, 2022 · 6 comments
Labels
🩵 Migrated to Featurebase Archive this issue and head to featurebase to follow plugin v2.1 Token viewing experience 💡request Community feedback token types

Comments

@chriskerr-performio
Copy link

Is your feature request related to a problem? Please describe.
We tokenise our icons. This helps us swap out sets for white-labelling for our clients. They are semantic icons, so have specific meaning for use in components and in our application.

At the moment, we add these under the Other category, and in the generated JSON, the group value is set to "Other".

We also name our token grouping slightly differently to the plugin. For example, I'd prefer to call "Typography", "textStyle" (shorter, i don't mistype it as much 😆).

Describe the solution you'd like
I'd also like to be able to customise the existing group values, overriding the defaults used today. Essentially expose this value in the token as populated, but editable field. Obviously this would benefit from broader bulk actions, but that's probably a seperate issue.

Describe alternatives you've considered
Currently I generate the JSON in Figma Tokens, then edit the group values by hand. This is obviously frustrating as I have to do it every time I update the tokens.

Additional context
None.

@six7
Copy link
Collaborator

six7 commented Aug 19, 2022

BTW You can just alter the type in the JSON, the plugin will respect that (until you save in the UI that is, which is an issue. But if all you need those tokens for is to have them stored for dev, then that'd work).

@chriskerr-performio
Copy link
Author

Yep this is what i do today for all my custom token types. it'd be cool to be able to be able to create a custom name (aka type) in the UI at the top level grouping

More importantly though, if you do change Type in the JSON, in the UI when you edit a token within that custom group, the type reverts to Other, which is super annoying..... obviously ideal case is that the user entered value is retained on Edit/Save

@six7
Copy link
Collaborator

six7 commented Aug 19, 2022

Yep this is what i do today for all my custom token types. it'd be cool to be able to be able to create a custom name (aka type) in the UI at the top level grouping

More importantly though, if you do change Type in the JSON, in the UI when you edit a token within that custom group, the type reverts to Other, which is super annoying..... obviously ideal case is that the user entered value is retained on Edit/Save

💯 that is annoying. Added it to one of our upcoming iterations: #1202

@chriskerr-performio
Copy link
Author

chriskerr-performio commented Aug 19, 2022 via email

@sir-captainmorgan21
Copy link

Is it a lot of work to add a "type" field for "Other" tokens? If type is left blank, set to other. Or are we thinking of adding the ability to add your own section, essentially removing the "other" group?

@SamIam4Hyma SamIam4Hyma added token types 💡request Community feedback plugin v2.1 Token viewing experience labels Mar 20, 2024
@UdayHyma
Copy link
Collaborator

Added to Featurebase Roadmap : 🪙 Expand token types

@SamIam4Hyma SamIam4Hyma added the 🩵 Migrated to Featurebase Archive this issue and head to featurebase to follow label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🩵 Migrated to Featurebase Archive this issue and head to featurebase to follow plugin v2.1 Token viewing experience 💡request Community feedback token types
Projects
Status: 🧑‍🎨 Shaping
Development

No branches or pull requests

5 participants