Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans on adding unit tests? #62

Closed
welch16 opened this issue Nov 29, 2022 · 2 comments
Closed

Plans on adding unit tests? #62

welch16 opened this issue Nov 29, 2022 · 2 comments

Comments

@welch16
Copy link

welch16 commented Nov 29, 2022

Hi @sjbeckett,

I was wondering if there are any plans to add unit tests with testthat or an alternative package. I know that other organizations like bioconductor or ropensci recommend adding unit tests.

I know the amount of work required to add tests to a package of the scope as this one, but I feel it would be enriched in the end.

Thanks

@sjbeckett
Copy link
Owner

Hi @welch16, many thanks for this suggestion!

I think we can implement unit testing on some, but not all of our core functionality - and wanted to scope out what this may look like. Given the dynamic nature of the datasets that we are working with within the package, the output of individual load function calls is non-deterministic, which we think would make unit testing challenging to implement across the entire package. Given this challenge, we have made some adjustments in our revisions to help user experience.

However, I think we could implement unit testing on some of our utility functions including tidy_Data and calcRisk.

@sjbeckett
Copy link
Owner

Unit tests for some core functions added with #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants