Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong loss function in paper/poster? #11

Closed
LiranPo opened this issue May 18, 2021 · 2 comments
Closed

Wrong loss function in paper/poster? #11

LiranPo opened this issue May 18, 2021 · 2 comments

Comments

@LiranPo
Copy link

LiranPo commented May 18, 2021

Hi,
I believe the paper and poster both show a loss function with contradictive parts: the first part (Lab) gets bigger as images are more different, whereas the second part (MS-SSIM) gets bigger as images are more similar.
image
The code, however, does not make that mistake, and actually the loss is Lab + (1 - MS-SSIM) (not sure why 1 is necessary).

@sjmoran
Copy link
Owner

sjmoran commented May 18, 2021

Hi @LiranPo, thank you for highlighting this typo - you are correct the loss should be Lab + (1-MS-SSIM) in the paper and in the poster.

@sjmoran sjmoran closed this as completed May 18, 2021
@LiranPo
Copy link
Author

LiranPo commented May 19, 2021

@sjmoran another note about the poster (screenshot above) - I believe you mean Lab and MS-SSIM account for global and local enhancement, respectively, not vice versa, as stated in your paper:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants