Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#[allow(non_snake_case)] #36

Closed
abrassel opened this issue May 17, 2024 · 3 comments · Fixed by #52
Closed

#[allow(non_snake_case)] #36

abrassel opened this issue May 17, 2024 · 3 comments · Fixed by #52
Assignees

Comments

@abrassel
Copy link
Contributor

Hi @sjrusso8 can you tell me the rationale behind exposing a camel cased API?

Seems like we should be fine just using idiomatic rust snake casing.

On a separate note, do you have an IM channel of some kind to chat about this project? I would love to iterate more rapidly with you.

@sjrusso8
Copy link
Owner

The only rationale was to match the existing API naming so that someone who is use to using scala or python could easily use the rust client crate. No other real reason :)

I’ll send you a message on slack.

@wvwwvwwv
Copy link

Hi! As a software developer who has experience in both spark-connect and Rust, I would prefer disallowing non_snake_cases in Rust code, because people who try to use this library are most likely knowledgeable about Rust and more comfortable with idiomatic Rust code.

@sjrusso8
Copy link
Owner

I've been thinking about it a lot and arrived at that same conclusion. Rust users would be expecting rust idiomatic code, not spark code. I can work on switching these around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants