Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename package #3

Closed
sjwiesman opened this issue Aug 20, 2020 · 2 comments
Closed

Rename package #3

sjwiesman opened this issue Aug 20, 2020 · 2 comments
Labels
good first issue Good for newcomers

Comments

@sjwiesman
Copy link
Owner

The current package statefun_go is not idiomatic with its underscore. We should rename it to something else.

I'm not sure if it is alright to have the package structure different from the file structure but the end goal is to donate this codebase to apache/flink-statefun which is a mono-repo containing multiple languages. This means will want some signifier that this package contains the go sdk specifically.

@sjwiesman sjwiesman added the good first issue Good for newcomers label Aug 20, 2020
@marcellanz
Copy link

One probably would have a separate repository for the go implementation here in the flink project especially which will have a descriptive name state that this is the go sdk of statefun perhaps something like: https://github.com/apache/flink-statefun-go and then having descriptive packages. File directory structure also follow the package structure. More about this can be found here:
https://golang.org/doc/effective_go.html#names
https://blog.golang.org/package-names

@sjwiesman
Copy link
Owner Author

Thanks for the resources!

fixed in bdd63ac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants