Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/skale 2360 overloading #181

Merged
merged 4 commits into from
Apr 27, 2020

Conversation

DimaStebaev
Copy link
Contributor

Rename functions to avoid overloading

@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #181 into develop will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #181      +/-   ##
===========================================
+ Coverage    92.76%   92.91%   +0.14%     
===========================================
  Files           34       34              
  Lines         2487     2483       -4     
  Branches       340      339       -1     
===========================================
  Hits          2307     2307              
+ Misses         180      176       -4     
Impacted Files Coverage Δ
contracts/delegation/DelegationController.sol 93.20% <100.00%> (+1.46%) ⬆️
contracts/delegation/PartialDifferences.sol 90.98% <100.00%> (ø)
contracts/delegation/TokenLaunchLocker.sol 98.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b523bd7...0fab949. Read the comment docs.

Copy link
Contributor

@payvint payvint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@DimaStebaev DimaStebaev merged commit c5e651b into develop Apr 27, 2020
@DimaStebaev DimaStebaev deleted the enhancement/SKALE-2360-overloading branch April 27, 2020 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants