Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tab size #3198

Merged
merged 5 commits into from
Jul 25, 2023
Merged

feat: tab size #3198

merged 5 commits into from
Jul 25, 2023

Conversation

d-hand
Copy link
Contributor

@d-hand d-hand commented Jul 6, 2023

Проблема

Добавить size для Tabs

Ссылки

https://yt.skbkontur.ru/issue/IF-1295/Dobavit-prop-Size-dlya-Tabs
https://yt.skbkontur.ru/issue/IF-807/Dobavit-propy-size-dlya-vseh-komponentov

Чек-лист перед запросом ревью

  1. Добавлены тесты на все изменения
    ⬜ unit-тесты для логики
    ✅ скриншоты для верстки и кросс-браузерности
    ⬜ нерелевантно

  2. Добавлена (обновлена) документация
    ✅ styleguidist для пропов и примеров использования компонентов
    ⬜ jsdoc для утилит и хелперов
    ⬜ комментарии для неочевидных мест в коде
    ⬜ прочие инструкции (README.md, contributing.md и др.)
    ⬜ нерелевантно

  3. Изменения корректно типизированы
    ⬜ без использования any (см. PR 2856)
    ✅ нерелевантно

  4. Прочее
    ⬜ все тесты и линтеры на CI проходят
    ⬜ в коде нет лишних изменений
    ⬜ заголовок PR кратко и доступно отражает суть изменений (он попадет в changelog)

packages/react-ui/components/Tabs/Tabs.md Outdated Show resolved Hide resolved
packages/react-ui/components/Tabs/Tabs.tsx Outdated Show resolved Hide resolved
packages/react-ui/components/Tabs/Tabs.styles.ts Outdated Show resolved Hide resolved
packages/react-ui/internal/themes/DefaultTheme.ts Outdated Show resolved Hide resolved
packages/react-ui/internal/themes/DefaultTheme.ts Outdated Show resolved Hide resolved
@zhzz zhzz merged commit 69b2299 into next Jul 25, 2023
@zhzz zhzz deleted the IF-1295-tab-size branch July 25, 2023 07:14
zhzz pushed a commit that referenced this pull request Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants