Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Checkbox): add prop size #3230

Merged
merged 17 commits into from
Aug 10, 2023
Merged

feat(Checkbox): add prop size #3230

merged 17 commits into from
Aug 10, 2023

Conversation

SchwJ
Copy link
Member

@SchwJ SchwJ commented Aug 3, 2023 •
edited
Loading

Проблема

Добавить проп size для Checkbox

Ссылки

https://yt.skbkontur.ru/issue/IF-1352
https://yt.skbkontur.ru/issue/IF-807/Dobavit-propy-size-dlya-vseh-komponentov

Чек-лист перед запросом ревью

  1. Добавлены тесты на все изменения
    ⬜ unit-тесты для логики
    ✅ скриншоты для верстки и кросс-браузерности
    ⬜ нерелевантно

  2. Добавлена (обновлена) документация
    ✅ styleguidist для пропов и примеров использования компонентов
    ⬜ jsdoc для утилит и хелперов
    ⬜ комментарии для неочевидных мест в коде
    ⬜ прочие инструкции (README.md, contributing.md и др.)
    ⬜ нерелевантно

  3. Изменения корректно типизированы
    ✅ без использования any (см. PR 2856)
    ⬜ нерелевантно

  4. Прочее
    ✅ все тесты и линтеры на CI проходят
    ✅ в коде нет лишних изменений
    ✅ заголовок PR кратко и доступно отражает суть изменений (он попадет в changelog)

@SchwJ SchwJ changed the title Checkbox size feat(Checkbox): add prop size Aug 3, 2023
@SchwJ SchwJ requested a review from zhzz August 7, 2023 06:07
@SchwJ
Copy link
Member Author

SchwJ commented Aug 8, 2023 •
edited
Loading

Скриншоты для size=medium также изменились, так как согласно макетам 2021 2022 gap = 8px вне зависимости от значения size

@SchwJ
Copy link
Member Author

SchwJ commented Aug 9, 2023 •
edited
Loading

Падают два мигающих теста (прогнала уже 3 раза)
image

@SchwJ SchwJ requested a review from zhzz August 9, 2023 05:04
zhzz
zhzz requested changes Aug 10, 2023
View reviewed changes
Copy link
Member

@zhzz zhzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Уже почти, еще пара комментариев :)

packages/react-ui/components/Checkbox/Checkbox.mixins.ts Outdated Show resolved Hide resolved
packages/react-ui/components/Checkbox/Checkbox.mixins.ts Outdated Show resolved Hide resolved
packages/react-ui/components/__stories__/baseline.stories.tsx Outdated Show resolved Hide resolved
packages/react-ui/internal/themes/DefaultTheme.ts Show resolved Hide resolved
@SchwJ SchwJ requested a review from zhzz August 10, 2023 09:20
zhzz
zhzz approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@zhzz zhzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zhzz zhzz merged commit 032279a into next Aug 10, 2023
@zhzz zhzz deleted the checkbox-size branch August 10, 2023 09:56
zhzz pushed a commit that referenced this pull request Sep 4, 2023
@SchwJ @zhzz
feat(Checkbox): add prop size (#3230)
2588419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhzz zhzz zhzz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SchwJ @zhzz