Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement animation and transition utility classes #1630

Closed
Tracked by #2449
datacurse opened this issue Jun 3, 2023 · 2 comments
Closed
Tracked by #2449

Implement animation and transition utility classes #1630

datacurse opened this issue Jun 3, 2023 · 2 comments
Labels
feature request Request a feature or introduce and update to the project.
Milestone

Comments

@datacurse
Copy link

Describe the feature in detail (code, mocks, or screenshots encouraged)

Problem

Currently, animations like hover effects for cards and shrinking effects for buttons are tied to specific component classes in Skeleton. This limits our ability to apply these animations to other elements or customize them without introducing unwanted styles from the associated classes.

Proposed Solution

I propose introducing a collection of standalone animation classes that can be applied to any element, independent of component classes. This separation of animations from specific components would provide more flexibility and control over the desired effects.

Benefits

  • Animation Flexibility: Users can apply a wide range of animations to any element, regardless of its class or structure.
  • Customization: By decoupling animations from component classes, we can avoid unnecessary styles and layout disruptions, resulting in cleaner and more coherent designs.
  • Expanded Use Cases: The ability to apply animations to various elements opens up new creative possibilities and extends the utility of the Skeleton framework.

Example Usage

<!-- Applying the 'animate-hover' class to any element to trigger a hover animation -->
<div class="animate-hover">
  <!-- Element content -->
</div>

<!-- Applying the 'animate-pressed' class to any element to simulate a pressed effect -->
<span class="animate-pressed">
  <!-- Element content -->
</span>

Considerations

  • Opt-In Approach: The animation classes should be optional, allowing users to choose which animations to apply based on their specific needs.
  • Backward Compatibility: Introducing these new animation classes as opt-in options ensures that existing Skeleton users are not affected by any breaking changes. Other classes like btn should remain their default animations, with optional ability to disable them.

What type of pull request would this be?

New Feature

Provide relevant links or additional information.

No response

@datacurse datacurse added the feature request Request a feature or introduce and update to the project. label Jun 3, 2023
@endigo9740 endigo9740 changed the title Separating Animations from Component Classes Implement animation and transition utility classes Jun 5, 2023
@endigo9740 endigo9740 reopened this Aug 29, 2023
@endigo9740
Copy link
Contributor

See also: #1738

@endigo9740 endigo9740 mentioned this issue Apr 1, 2024
11 tasks
@endigo9740
Copy link
Contributor

I'm going to fold this under a more widespread issue here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request a feature or introduce and update to the project.
Projects
None yet
Development

No branches or pull requests

2 participants