Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeViewItem does not work with Svelte 5 #2502

Closed
notramo opened this issue Feb 22, 2024 · 2 comments
Closed

TreeViewItem does not work with Svelte 5 #2502

notramo opened this issue Feb 22, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@notramo
Copy link

notramo commented Feb 22, 2024

Current Behavior

It seems it's using a children attribute which is reserved in Svelte 5 for the default snippet.

Expected Behavior

Rename children to childNodes or similar.

Steps To Reproduce

Use TreeViewItem in a Svelte 5 project.

@notramo notramo added the bug Something isn't working label Feb 22, 2024
@endigo9740
Copy link
Contributor

endigo9740 commented Feb 22, 2024

Use TreeViewItem in a Svelte 5 project.

You shouldn't be using this yet:

One of the key focuses of Skeleton v3 (our next major version) is support for Svelte 5. In other words, please stick with Svelte 4 while running Skeleton v2.x. Otherwise you're asking for trouble!

I'm going to assign this to @Mahmoud-zino (author of the Tree View feature) to determine if this is relevant to fix for Skeleton v3, given we do expect other changes to occur as part of the process of porting from Svelte 4 -> 5. I will defer to his opinion on this.

@Mahmoud-zino
Copy link
Contributor

This is not a bug, there was no way we could have predicted that 😄
However this will change for sure in Skeleton v3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants