Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Add plugin homepage field #33

Open
mludowise opened this issue Jun 13, 2017 · 3 comments
Open

[API] Add plugin homepage field #33

mludowise opened this issue Jun 13, 2017 · 3 comments

Comments

@mludowise
Copy link

Some plugins have homepages defined in the Plugin Directory, in their GitHub project, or in their manifest file.

I currently link to the homepage for each plugin in Sketch Plugin Manager using the following priority:

  1. If a homepage is defined in the plugin-directory
  2. If a homepage is defined in the manifest file of the plugin.
  3. If a homepage is defined in the GitHub project (retrieved via the GitHub API).
  4. The GitHub page of the plugin if none of the above exist.

In order to start using the Sketchpacks API, I would require for their to be a homepage defined for each plugin in the API.

@willdavis
Copy link

willdavis commented Jun 14, 2017

I can definitely add the manifest.homepage property to the Plugin model.
That's an easy addition.

Can you please expand on points 3, and 4 though?

The Plugin.source_url points to the Github repository, so I think you can use that for 4?
Which Github API endpoint are you using to grab the homepage?

@adamkirkwood
Copy link
Member

@mludowise Ideally, it would be great for you to link to a plugin page on Sketchpacks.com.

We plan on iterating on the actual registry website in an upcoming sprint.

This would solve for when a plugin does not have an actual homepage, but also allow us to surface more details such as key bindings, analytics, etc.

@paulvantuyl
Copy link

If I’m following along correctly, would this add a link to each plugin’s homepage from the Plugin Name in the Sketchpacks menu? I would love to be able to copy a link from here to share plugins with coworkers or open the plugin homepage so they can verify they are installing the correct plugin.

screen shot 2018-04-26 at 1 37 51 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants