[CLEANUP] Cleaned up #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Cleaned up model column names. - Added request() helper function for request related functions. - Renamed \Pecee\Language class to \Pecee\Translation - as it's more logical. - Removed Server class as methods are availible through the request() helper. - Simplified Model class by removing __call magic method. Auto getting and settings methods: getId() no longer returns id. unless a custom method has been created. - Cleaned up code.
- Cleaned up Collection class. - Removed methods from Controller class which is already there through the Base inherited class (issue: #12). - Renamed asJSON to asJson in Controller class. - Made asJson class use response class. - Translated error exceptions in Image class. - Removed validation stuff from Form class as it doesn't belong there. - Optimised FileAbstract class so it now uses response class. - Removed $_GET from FileAbstract class as it inherits from the BaseController. - Other optimisations and cleanups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logical.
helper.
and settings methods: getId() no longer returns id.
unless a custom method has been created.