Removed is_Mul heuristic in Limit.doit() #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skirpichev
force-pushed
the
remove-is_Mul-heuristic
branch
from
9de415d
to
e967cfd
Compare
skirpichev
force-pushed
the
remove-is_Mul-heuristic
branch
from
e967cfd
to
4b31e4d
Compare
skirpichev
force-pushed
the
remove-is_Mul-heuristic
branch
from
4b31e4d
to
7d95efa
Compare
skirpichev
force-pushed
the
remove-is_Mul-heuristic
branch
from
7d95efa
to
2e6c4f9
Compare
skirpichev
force-pushed
the
remove-is_Mul-heuristic
branch
from
dc43eba
to
8986b56
Compare
skirpichev
force-pushed
the
remove-is_Mul-heuristic
branch
from
7856baf
to
3210ca0
Compare
skirpichev
force-pushed
the
remove-is_Mul-heuristic
branch
2 times, most recently
from
d355307
to
227fca0
Compare
This patch introduces a performance regression (very non-trivial to fix), but given the number of bugs fixed and that old heuristics was completely wrong - I believe this is a fair trade. Closes sympy/sympy#10610 Closes sympy/sympy#9075 (I don't think this is all, but who cares.)
skirpichev
force-pushed
the
remove-is_Mul-heuristic
branch
from
a892d12
to
bfc28bc
Compare
A slightly different fix, based on @leosartaj's solution in sympy/sympy#9175.
skirpichev
force-pushed
the
remove-is_Mul-heuristic
branch
from
bfc28bc
to
13ca507
Compare
skirpichev
added a commit
that referenced
this pull request
Feb 21, 2016
Removed is_Mul heuristic in Limit.doit()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.