Misc no-cache fixes #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skirpichev
force-pushed
the
no-cache-fixes
branch
2 times, most recently
from
ba7e730
to
63dc189
Compare
This can handle seeing one arg which is_positive/is_negative=False. If
there's more than one is_positive/is_negative=False arg, all bets are
off. It becomes a multiplication between non-reals. The result of the
Mul could then be positive, negative, not real etc. This is why I count
the number of is_positive/is_negative=False args.
This is also one of the changes needed to fix the infinite recursion bug
when the cache is turned off. The (-self).is_positive call actually has
side effects that causes Mul._eval_is_negative to perform these
is_positive/is_negative = False checks for some reason (without this
commit). This is why I explicitly add it to the _eval_is_positive case.
Example:
mx = -Symbol('x', negative=False)
assert mx.is_positive is False # will pass now
px = 2*Symbol('x', positive=False)
assert px.is_positive is False # will pass now
Refactor some assumptions helpers for Mul to reduce circularity. Fixes sympy/sympy#8840, fixes sympy/sympy#9413, fixes sin(x + x).
skirpichev
force-pushed
the
no-cache-fixes
branch
from
63dc189
to
c459d18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
sympy/sympy#9379
sympy/sympy#8840
sympy/sympy#9376
sympy/sympy#9374
sympy/sympy#9194
sympy/sympy#9421
sin(x+x)