Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Parse #10

Closed
IDM3 opened this issue Jun 4, 2021 · 3 comments
Closed

Incorrect Parse #10

IDM3 opened this issue Jun 4, 2021 · 3 comments

Comments

@IDM3
Copy link

IDM3 commented Jun 4, 2021

When using syntax similar to "1d20-1", it parses it to 1d20.success-1, instead of parsing to math as would be expected, checked the dice expression documentation and it seems to be an issue.

@skizzerz
Copy link
Owner

skizzerz commented Jun 4, 2021

I'm unable to reproduce this issue on the latest release. What specific roll were you using to encounter this issue?

If you are using the latest code from the master branch, don't (unless you are explicitly testing future library versions for regression, in which case do and thanks!). Alpha versions are unstable and the current codebase is broken in quite a few ways. Only install via NuGet or a release tag.

@skizzerz
Copy link
Owner

skizzerz commented Jun 4, 2021

Was able to reproduce on the latest alpha version and implemented a fix, as well as some tests to catch it should it come up again. To recap what I said earlier (since it wasn't entirely clear)

  • For all production uses of this library, stick to stable releases (via NuGet or release tags). The latest version found in the master branch is not guaranteed to be stable, and right now there are a handful of known bugs with it.
  • Use the master branch only for testing the library itself or for testing library changes in a test/alpha branch of your codebase. If doing the latter, expect that the API is not stable and may cause breaking changes between commits.

In either case, it's helpful to report which version you encountered the bug on :)

@skizzerz skizzerz closed this as completed Jun 4, 2021
@IDM3
Copy link
Author

IDM3 commented Jun 4, 2021

will do in the future thanks (For the record, yeah I forked the repository and added it instead of nuget in an effort to try and help contribute, since I found the library useful, I'm just using it for a discord bot, to help with a server I'm running. I reverted it back to the release tag)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants