-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect Parse #10
Comments
I'm unable to reproduce this issue on the latest release. What specific roll were you using to encounter this issue? If you are using the latest code from the master branch, don't (unless you are explicitly testing future library versions for regression, in which case do and thanks!). Alpha versions are unstable and the current codebase is broken in quite a few ways. Only install via NuGet or a release tag. |
Was able to reproduce on the latest alpha version and implemented a fix, as well as some tests to catch it should it come up again. To recap what I said earlier (since it wasn't entirely clear)
In either case, it's helpful to report which version you encountered the bug on :) |
will do in the future thanks (For the record, yeah I forked the repository and added it instead of nuget in an effort to try and help contribute, since I found the library useful, I'm just using it for a discord bot, to help with a server I'm running. I reverted it back to the release tag) |
When using syntax similar to "1d20-1", it parses it to 1d20.success-1, instead of parsing to math as would be expected, checked the dice expression documentation and it seems to be an issue.
The text was updated successfully, but these errors were encountered: