Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registry.sol: Add event _ListingTouchAndRemoved(bytes32 listingHash); #45

Closed
eccheung4 opened this issue Mar 27, 2018 · 3 comments
Closed

Registry.sol: Add event _ListingTouchAndRemoved(bytes32 listingHash); #45

eccheung4 opened this issue Mar 27, 2018 · 3 comments
Labels
enhancement

Comments

@eccheung4
Copy link

This helps distinguish when a listing has been touched and removed instead of just a listing has been removed.
@kangarang
Copy link
Collaborator

Great suggestion @eccheung4 .

How bout _TouchAndRemove?

@kangarang kangarang mentioned this issue Mar 27, 2018
Closed
@eccheung4
Copy link
Author

I like either:

_LIstingTouchAndRemoved
or
_TouchAndRemoved

since other events are similarly past tense

@kangarang kangarang mentioned this issue Mar 29, 2018
Closed
@kangarang
Copy link
Collaborator

Resolved:

cab98ed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eccheung4 @skmgoldin @kangarang