Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs for init_containers #49

Closed
botzill opened this issue Dec 26, 2019 · 5 comments · Fixed by #140
Closed

Add logs for init_containers #49

botzill opened this issue Dec 26, 2019 · 5 comments · Fixed by #140
Labels
good first issue Good for newcomers hacktoberfest Tasks for hacktoberfest

Comments

@botzill
Copy link

botzill commented Dec 26, 2019

Currently init containers does not have logs and would be nice to have them.

@herbrandson
Copy link
Collaborator

@botzill I'm not sure I understand. Could you provide more details about what you're looking for?

@botzill
Copy link
Author

botzill commented Jan 4, 2020

HI.

We can have container logs and we can have init containers log. Current k8s dashboard show it like this:

Screen Shot 2020-01-04 at 11 07 51

Same way wold be nice to have it here.

@botzill
Copy link
Author

botzill commented Mar 22, 2020

Hi.

Do you think this feature is hard to add?

@herbrandson
Copy link
Collaborator

Het @botzill. I took a quick look and this doesn't look like it's going to be too difficult. Currently the list of containers is built in client/src/views/logs.js by grabbing the pod.spec.containers collection. Looking at the docs there's also an optional pod.spec.initContainers collection that should have the needed info. The most difficult part is probably going to be updating the react-select control to use groups (similar to your screenshot above). But looking at StackOverflow, it seems like that should be pretty straight forward too.

Is this something you'd like to take a crack at? If not, I may have some time to give it a try in the next week or 2. Let me know :)

@herbrandson herbrandson added the good first issue Good for newcomers label May 5, 2020
@Zacharias3690
Copy link

Currently working on this if you wouldn't mind assigning me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Tasks for hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants