Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign alias should not include wall and floor signs when not specified #94

Closed
sovdeeth opened this issue Jul 29, 2023 · 3 comments
Closed
Labels
enhancement New feature or request

Comments

@sovdeeth
Copy link
Member

sovdeeth commented Jul 29, 2023

Found by @arcsin0.5 on skript chat discord.

When using oak sign or spruce sign as an item, eg: giving it to player or setting a slot, the alias can resolve to either floor sign or a wall sign, and a wall sign cannot be given as an item. So half the time giving a sign or setting a slot will silently fail, when not specifying floor.

The alias should always return a floor sign, like torch always returns a floor torch.

[floor] torch¦es = minecraft:torch
any torch = floor torch, north facing wall torch, south facing wall torch, east facing wall torch, west facing wall to…

any oak sign should still include wall signs, but oak sign alone should not.

@Fusezion
Copy link

honestly I think something needs to be done to stop band aiding it.
Just forcing it to default to floor (whatever) when only (whatever) is used doesn't solve the underlining issue.

A method for forcing wall (whatever) or hanging (whatever) to their item format needs to be added not only for those but any as well. if I understand enough it means give player any sign would end up giving no item meaning we're just covering up the issue.

@TheLimeGlass
Copy link
Contributor

TheLimeGlass commented Jul 29, 2023

#88 addresses signs. If this is valid, torches would need work.

@TheLimeGlass TheLimeGlass added the enhancement New feature or request label Jul 29, 2023
@TheLimeGlass
Copy link
Contributor

Duplicate as in terms of the inventories SkriptLang/Skript#5586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants