Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NotSerializableException when using "end rod" aliases/visual effect #6555

Closed
1 task done
Fusezion opened this issue Apr 12, 2024 · 4 comments
Closed
1 task done

NotSerializableException when using "end rod" aliases/visual effect #6555

Fusezion opened this issue Apr 12, 2024 · 4 comments
Labels
duplicate For bugs or requests that have already been made and are currently open.

Comments

@Fusezion
Copy link
Contributor

Skript/Server Version

[02:18:49 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[02:18:49 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[02:18:49 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[02:18:49 INFO]: [Skript] Server Version: git-Paper-430 (MC: 1.20.4)
[02:18:49 INFO]: [Skript] Skript Version: 2.8.4 (skriptlang-github)
[02:18:49 INFO]: [Skript] Installed Skript Addons:
[02:18:49 INFO]: [Skript]  - skript-gui v1.3 (https://github.com/APickledWalrus/skript-gui)
[02:18:49 INFO]: [Skript]  - skript-yaml v1.5
[02:18:49 INFO]: [Skript]  - skript-particle v1.2.0 (https://github.com/sovdeeth/skript-particle)
[02:18:49 INFO]: [Skript]  - skript-reflect v2.4-dev2 (https://github.com/SkriptLang/skript-reflect)
[02:18:49 INFO]: [Skript]  - SkBee v3.4.2 (https://github.com/ShaneBeee/SkBee)
[02:18:49 INFO]: [Skript] Installed dependencies: None

Bug Description

When attempting to set a variable to end rod on on load, skript throws a NotSerializableException for visual effect classinfo.
This does not appear to happen when using an effect command.

Expected Behavior

Don't throw me a stack trace when all I want is an end rod

Steps to Reproduce

on load:
    set {_test} to end rod
    # set {_test::*} to end rod

Errors or Screenshots

stack trace https://gist.github.com/Fusezion/7a28bb28fa43cef5572870032957173d

Other

This error was brought to my attention by a discord user, and testing shows this was created in the 2.8.4 release 2.8.3 and below have no issues

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@Romitou
Copy link
Member

Romitou commented Apr 12, 2024

Can't replicate with same addons.

[22:33:31 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[22:33:31 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[22:33:31 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[22:33:31 INFO]: [Skript] Server Version: git-Paper-483 (MC: 1.20.4)
[22:33:31 INFO]: [Skript] Skript Version: 2.8.4 (skriptlang-github)
[22:33:31 INFO]: [Skript] Installed Skript Addons:
[22:33:31 INFO]: [Skript]  - skript-gui v1.3 (https://github.com/APickledWalrus/skript-gui)
[22:33:31 INFO]: [Skript]  - skript-particle v1.2.0 (https://github.com/sovdeeth/skript-particle)
[22:33:31 INFO]: [Skript]  - skript-reflect v2.4 (https://github.com/SkriptLang/skript-reflect)
[22:33:31 INFO]: [Skript]  - SkBee v3.4.3 (https://github.com/ShaneBeee/SkBee)
[22:33:31 INFO]: [Skript] Installed dependencies: None

@Fusezion
Copy link
Contributor Author

Can't replicate with same addons.

Hmm you shouldn't need any addons, as the person who reported this to me stated he had no addons when attempting this and his stacktrace shows it as well.
Message history started here. https://discord.com/channels/135877399391764480/138027100593455104/1228222235848736820

@Fusezion
Copy link
Contributor Author

Alright so after testing my step to reproduce was incorrect, using local vars doesn't cause an issue as skript shouldn't check for serializable state using a global var such as {blah} or {blah::*} was able to cause this, sorry for confusion I thought when I tried it prior it errored

@sovdeeth
Copy link
Member

Duplicate of #4196

@sovdeeth sovdeeth marked this as a duplicate of #4196 Apr 14, 2024
@sovdeeth sovdeeth closed this as not planned Won't fix, can't repro, duplicate, stale Apr 14, 2024
@sovdeeth sovdeeth added the duplicate For bugs or requests that have already been made and are currently open. label Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate For bugs or requests that have already been made and are currently open.
Projects
None yet
Development

No branches or pull requests

3 participants