Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop referencing the old Converter class in PropertyExpression #6685

Open
1 task done
TheLimeGlass opened this issue May 10, 2024 · 2 comments
Open
1 task done

Stop referencing the old Converter class in PropertyExpression #6685

TheLimeGlass opened this issue May 10, 2024 · 2 comments

Comments

@TheLimeGlass
Copy link
Collaborator

TheLimeGlass commented May 10, 2024

Suggestion

Stop referencing the old Converter class in PropertyExpression

protected T[] get(final F[] source, final ch.njol.skript.classes.Converter<? super F, ? extends T> converter) {

This restricts the usage of method references Block::getExample by using the old converter class giving an IDE warning about using deprecated classes.

Why?

To enforce the method reference code standard by resolving the class deprecation versioning.

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this suggestion.
@APickledWalrus
Copy link
Member

APickledWalrus commented May 10, 2024

It currently uses the old classes for compatibility reasons, see #5507

@TheLimeGlass
Copy link
Collaborator Author

It currently uses the old classes for compatibility reasons, see #5507

Yes, but it needs to be replaced/overloaded with another method or finally removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants