Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weather expression does not work with world variables #6765

Open
1 task done
ShaneBeee opened this issue Jun 4, 2024 · 3 comments
Open
1 task done

Weather expression does not work with world variables #6765

ShaneBeee opened this issue Jun 4, 2024 · 3 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@ShaneBeee
Copy link
Contributor

Skript/Server Version

[15:48:01 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[15:48:01 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[15:48:01 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[15:48:01 INFO]: [Skript] Server Version: 1.20.6-130-5d8e53d (MC: 1.20.6)
[15:48:01 INFO]: [Skript] Skript Version: 2.8.6 (selfbuilt-unknown)
[15:48:01 INFO]: [Skript] Installed Skript Addons: 
[15:48:01 INFO]: [Skript]  - skNoise v1.0.1
[15:48:01 INFO]: [Skript]  - skript-reflect v2.4 (https://github.com/SkriptLang/skript-reflect)
[15:48:01 INFO]: [Skript]  - SkBee v3.5.2 (https://github.com/ShaneBeee/SkBee)
[15:48:01 INFO]: [Skript]  - SkBriggy v1.3.1
[15:48:01 INFO]: [Skript] Installed dependencies: 
[15:48:01 INFO]: [Skript]  - Vault v1.7.3-b131

Bug Description

I recently noticed the weather expression does not work with world variables.

Expected Behavior

It should work with variables

Steps to Reproduce

2 issues here:

command /test:
	trigger:
		set {_w} to world of player
		set weather in {_w} to rain

produces the following error:

[15:48:50 INFO]: Line 61: (test.sk)
[15:48:50 INFO]:     weather type within {_w} can't be set to anything
[15:48:50 INFO]:     Line: set weather in {_w} to rain

it doesn't appear to like weather in which im assuming is a class with the (%*type%|value[s]) (within|in) %~objects% expression.

second:

command /test:
	trigger:
		set {_w} to world of player
		set weather of {_w} to rain

This one simply just does nothing

Errors or Screenshots

No response

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@Pikachu920
Copy link
Member

for the first issue, I think it would be pretty simple to just disallow weather as a classinfo in the values within expression. I doubt anyone is ever trying to do that lol.

@sovdeeth
Copy link
Member

sovdeeth commented Jun 7, 2024

The second is conflicting with the [custom] weather of %players% syntax. @Moderocky want to make an AnyWeather type?

@sovdeeth sovdeeth added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. labels Jun 7, 2024
@Moderocky
Copy link
Member

The second is conflicting with the [custom] weather of %players% syntax. @Moderocky want to make an AnyWeather type?

Sure, but it might take me some time to get around to it so you're welcome to add it yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Development

No branches or pull requests

4 participants