Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT Use importlib + packaging instead of pkg_resources #648

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

jeremiedbb
Copy link
Contributor

@jeremiedbb jeremiedbb commented Jul 18, 2023

Fixes #550

the goal is to get rid of this

# TODO we should probably deal with those
'ignore:pkg_resources\ is\ deprecated\ as\ an\ API:DeprecationWarning',
'ignore:Deprecated\ call\ to\ `pkg_resources:DeprecationWarning',

usage of pkg_resources is deprecated. There's still no way to use only importlib to do the same thing, at least without having to manually parse the requirements. This PR uses packaging instead that provides tools to parse the requirements.

Like pkg_resources, packaging is not in the std lib, but is very likely to be installed since it comes with pip. And at least this one is not deprecated :)

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@LilianBoulard LilianBoulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor changes (which I'll commit) and we're good to merge, thanks!

skrub/_check_dependencies.py Outdated Show resolved Hide resolved
skrub/_check_dependencies.py Outdated Show resolved Hide resolved
@LilianBoulard LilianBoulard merged commit 0a73df6 into skrub-data:main Jul 19, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg_ressources is deprecated
3 participants