Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Roave/BetterReflection & phpDocumentor/TypeResolver #11

Open
jakubkulhan opened this issue Nov 15, 2015 · 0 comments
Open

Use Roave/BetterReflection & phpDocumentor/TypeResolver #11

jakubkulhan opened this issue Nov 15, 2015 · 0 comments

Comments

@jakubkulhan
Copy link
Contributor

Meta currently wraps PHP's type system (https://github.com/skrz/meta/tree/master/src/Skrz/Meta/Reflection) and uses standard PHP reflection. It has several downsides:

  • class has to be loaded in the memory -- there cannot be long-running deamon that would compile meta classes incrementally after the file change
  • because class can reference other classes, everything has to be saved on the filesystem (the problem arises when being used as protoc-gen-php)

Consider replacing standard PHP reflection with Roave/BetterReflection and type system wrapping with phpDocumentor/TypeResolver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant