Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] numpy 2 compatibility #394

Closed
fkiraly opened this issue Jun 16, 2024 · 3 comments
Closed

[MNT] numpy 2 compatibility #394

fkiraly opened this issue Jun 16, 2024 · 3 comments
Labels
maintenance Continuous integration, unit testing & package distribution

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented Jun 16, 2024

numpy 2 has been released. We should test framework and all estimators for compatibility, and bump the version with the next MINOR release.
@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Jun 16, 2024
@fkiraly fkiraly mentioned this issue Jun 16, 2024
Closed
@fkiraly
Copy link
Collaborator Author

fkiraly commented Jun 16, 2024

From #393, framework is compatible without any issues.

@fkiraly
Copy link
Collaborator Author

fkiraly commented Jun 17, 2024

From #395, everything including all estimators is compatible without any issues. Minor restriction is that, in case of soft dependencies, we know this only for packages that already support numpy 2, but I would not expect any major problems as interface code does not use numpy typically, and if it does, only very superficially.

@fkiraly
Copy link
Collaborator Author

fkiraly commented Jun 17, 2024

Meaning, we can bump the numpy bound in 2.4.0.

@fkiraly fkiraly closed this as completed Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fkiraly