Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line numbers in diffs are off by the number of snapshot header fields #51

Closed
skuzzle opened this issue Dec 22, 2022 · 0 comments
Closed
Labels
bug Something isn't working

Comments

@skuzzle
Copy link
Owner

skuzzle commented Dec 22, 2022

Our rendered diffs contain line numbers that are based on the raw test output. Snapshot files however contain some extra header lines at the beginning of the file. Thus, when looking up changed lines in the actual snapshot file, the numbers reported in the diff are off by the number of header lines in the snapshot file.

I think we should adjust the reported line numbers by the amount of header lines so that it is easy to find the respective lines in the persisted snapshot file

@skuzzle skuzzle added the bug Something isn't working label Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant