Update dependencies #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aecay
reviewed
Nov 11, 2021
| @@ -29,6 +29,7 @@ func CreateCertificates(cn, destDir string) (certFile, keyFile string) { | |||
| Subject: pkix.Name{ | |||
| CommonName: cn, | |||
| }, | |||
| DNSNames: []string{cn}, | |||
There was a problem hiding this comment.
Wonderful 🎉 I think this change lgtm but we will probably want a second opinion from someone who is more experienced with the osprey. @howardburgess has reviewed osprey changes for me before so maybe he can do the honors...
There was a problem hiding this comment.
LGTM! (Sorry for delay, was on hols)
zemanlx
force-pushed
the
update-dependencies
branch
from
51d3e59
to
54fa5c9
Compare
howardburgess
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes vulnerable dependencies and as a bonus, it fixes #65.