-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #71
Conversation
@@ -29,6 +29,7 @@ func CreateCertificates(cn, destDir string) (certFile, keyFile string) { | |||
Subject: pkix.Name{ | |||
CommonName: cn, | |||
}, | |||
DNSNames: []string{cn}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this change solve #65?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful 🎉 I think this change lgtm but we will probably want a second opinion from someone who is more experienced with the osprey. @howardburgess has reviewed osprey changes for me before so maybe he can do the honors...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (Sorry for delay, was on hols)
51d3e59
to
54fa5c9
Compare
Fixes vulnerable dependencies and as a bonus, it fixes #65.